Hi, i've got planar embedding of K_4 which is not planar, but when I test it with is_planar(on_embeding=emb), it says that it is planar. Code:
g = graphs.CompleteGraph(4)
g.is_planar(set_embedding=True)
True
emb = {0 : [2,3,1], 1: [2,3,0], 2: [1,3,0], 3:[0,1,2]}
g.is_planar(on_embedding=emb)
True
So, what am I doing wrong?
Hello !
You did nothing wrong, and just came across a bug. I fixed it in ticket 18045 [1], but this code will only make it into Sage when somebody will have taken the time to review it (everybody can do it).
If you use this code often, it would help if you could learn our workflow a bit to help us. The 'embedding/planarity' part of Sage's graph code has been written a long time ago, and while I fix it from time to time I never use it myself and do not know the code very well.
Have fuuuuuuuuuuuuuun,
Nathann
Thanks! This was the second time I used Sage for planarity testing, so I thought it was rather my mistake. By the way, why were the computations run on cached embedding, instead of mine? (I did't get from the report)
Because some subfunction of Sage accepts True/False or a dictionary for on_embedding. When checking if the value is equal to True the code read "if on_embedding", but that branch was also taken when on_embedding was a dictionary (i.e. when an embedding is provided). I just moved the test for a dictionary before the test for boolean answers, and that was the end of it. This, and some documentation fixes ;-)
Ah, I see, thanks. So, do you have any idea how much I can trust this this function (the version before you made it right)? I'm trying to Boyer-Myrvold in C++ and I wanted to use Sage for checking output of my program.
Asked: 2015-03-24 12:19:41 +0100
Seen: 406 times
Last updated: Mar 24 '15
Copyright Sage, 2010. Some rights reserved under creative commons license. Content on this site is licensed under a Creative Commons Attribution Share Alike 3.0 license.
