Ask Your Question

Revision history [back]

click to hide/show revision 1
initial version

What tests are useful while reviewing a patch if the patchbot report is already positive?

Hi,

the sage developer guide lists several tests that should be performed manually during the review process, like a complete doctest, building the documentation and checking coverage. Are all these test necessary and useful, if the patch bot already reported, that the patch has been positively tested against the latest pre-release? Or can some be simply skipped because they are already checked by the bot? What does the bot actually check?

click to hide/show revision 2
retagged

What tests are useful while reviewing a patch if the patchbot report is already positive?

Hi,

the sage developer guide lists several tests that should be performed manually during the review process, like a complete doctest, building the documentation and checking coverage. Are all these test necessary and useful, if the patch bot already reported, that the patch has been positively tested against the latest pre-release? Or can some be simply skipped because they are already checked by the bot? What does the bot actually check?