What tests are useful while reviewing a patch if the patchbot report is already positive?

asked 2013-09-05 18:04:42 +0100

twch
368 ●3 ●13 ●21

updated 2015-01-14 11:52:40 +0100

FrédéricC

5311 ●4 ●44 ●118

Hi,

the sage developer guide lists several tests that should be performed manually during the review process, like a complete doctest, building the documentation and checking coverage. Are all these test necessary and useful, if the patch bot already reported, that the patch has been positively tested against the latest pre-release? Or can some be simply skipped because they are already checked by the bot? What does the bot actually check?

edit retag flag offensive close merge delete

add a comment

1 Answer

Sort by » oldest newest most voted

answered 2013-09-05 22:01:07 +0100

kcrisman
12242 ●42 ●136 ●255

You can always do them again - just because the bot is happy doesn't mean a different platform/chip won't have different results. Especially ones in the directories touched by the patch.

Also, tests other than the ones in the doc are the most useful! Use your imagination.

edit flag offensive delete link

Comments

I would add that the kind of review to focus on is that which cannot be automated, e.g. is the code understandable and well commented (and correct). Are the examples illustrative and the tests complete? Is the documentation up to par? Etc.

robertwb ( 2018-08-01 18:36:51 +0100 )edit

add a comment

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2013-09-05 18:04:42 +0100

Seen: 551 times

Last updated: Sep 05 '13

What tests are useful while reviewing a patch if the patchbot report is already positive? edit