ASKSAGE: Sage Q&A Forum - RSS feedhttps://ask.sagemath.org/questions/Q&A Forum for SageenCopyright Sage, 2010. Some rights reserved under creative commons license.Thu, 23 Jan 2014 16:22:06 +0100simplify_full - is the mistake in the documentation or the source code?https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/Looking at the simplify_full documentation in Sage 6.0, it says that it
> Applies simplify_factorial,
> simplify_trig, simplify_rational,
> simplify_radical, simplify_log, and
> again simplify_rational to self (in
> that order).
However the source code is
def simplify_full(self):
x = self
x = x.simplify_factorial()
x = x.simplify_trig()
x = x.simplify_rational()
x = x.simplify_log('one')
x = x.simplify_rational()
return x
So where is the mistake? Should simplify_radical be added to the source code or removed from the documentation?Fri, 17 Jan 2014 16:38:00 +0100https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/Answer by tmonteil for <p>Looking at the simplify_full documentation in Sage 6.0, it says that it </p>
<blockquote>
<p>Applies simplify_factorial,
simplify_trig, simplify_rational,
simplify_radical, simplify_log, and
again simplify_rational to self (in
that order).</p>
</blockquote>
<p>However the source code is</p>
<pre><code>def simplify_full(self):
x = self
x = x.simplify_factorial()
x = x.simplify_trig()
x = x.simplify_rational()
x = x.simplify_log('one')
x = x.simplify_rational()
return x
</code></pre>
<p>So where is the mistake? Should simplify_radical be added to the source code or removed from the documentation?</p>
https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/?answer=15937#post-id-15937Good catch ! `simplify_radical()` was removed from `simplify_full()` and `full_simplify()` in [trac ticket 12737](http://trac.sagemath.org/ticket/12737), but not from the documentation. I created [trac ticket 15693](trac.sagemath.org/ticket/15693) to solve this.
Thanks for reporting.Sat, 18 Jan 2014 08:53:16 +0100https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/?answer=15937#post-id-15937Comment by kcrisman for <p>Good catch ! <code>simplify_radical()</code> was removed from <code>simplify_full()</code> and <code>full_simplify()</code> in <a href="http://trac.sagemath.org/ticket/12737">trac ticket 12737</a>, but not from the documentation. I created <a href="trac.sagemath.org/ticket/15693">trac ticket 15693</a> to solve this.</p>
<p>Thanks for reporting.</p>
https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/?comment=16405#post-id-16405There is a fix up as well, so hopefully this will be done soon.Thu, 23 Jan 2014 16:22:06 +0100https://ask.sagemath.org/question/10939/simplify_full-is-the-mistake-in-the-documentation-or-the-source-code/?comment=16405#post-id-16405